Repository navigation
fix(browser): delegate off, window_bounds, tracing, activate and document_size to page - #714
Merged
Merged
Conversation
…ment_size to page Browser delegated on but not off, position but not window_bounds, and missed tracing, activate and document_size. Document that browser.command goes to the browser itself, unlike on, which subscribes on the default page. Also fix two RBS signatures: drop set_window_bounds, which no longer exists, and protected in Deadline, which RBS can't parse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browseris kept as a facade over its default page, but some page methods were missing from it: it delegatedonbut notoff,positionbut notwindow_bounds, and lackedtracing,activateanddocument_size. This adds them.browser.commandstays a command to the browser itself (Browser.*,Target.*), unlikebrowser.on, which subscribes on the default page. The YARD docs and a new "Raw CDP" section in the introduction guide now say so.Also fixes two RBS signatures:
Page#set_window_bounds, a method that no longer exists, is removed, andprotectedis dropped fromDeadline, since RBS can't parse it.